search

uw-comphys / opencmp

OpenCMP is a computational multiphysics software package based on the finite element method. It is primarily intended for physicochemical processes involving significant convective flow.
https://opencmp.io/
GNU Lesser General Public License v2.1
26 stars 15 forks source link

JOSS tutorial 9 #21

Closed bonh closed 2 years ago

bonh commented 2 years ago

Running python3 visualizationresults in 

importing NGSolve-6.2.2105
Traceback (most recent call last):
  File "visualization.py", line 8, in <module>
    from opencmp.helpers.ngsolve_ import ngsolve_to_numpy
ImportError: cannot import name 'ngsolve_to_numpy' from 'opencmp.helpers.ngsolve_' (/root/opencmp/opencmp/helpers/ngsolve_.py)

I am on branch publications, is that wrong?

bonh commented 2 years ago

Okay, I definitely shouldn't be on publications. Trying again on main...

bonh commented 2 years ago

Mhhh, no, I am confused, sry. On main I am not able to execute python3 visualization as that file is not there?

nasserma commented 2 years ago

Please use the publications branch, you have found a bug introduced by some refactoring we just did. I will fix this over the weekend.

bonh commented 2 years ago

Did you fix it? I am asking because it is still not working for me.

nasserma commented 2 years ago

Did you fix it? I am asking because it is still not working for me.

We did fix the issue and update the publications branch with the fix, just to confirm, did you reinstall the package before trying again?

bonh commented 2 years ago

Don't know what was going on, but now it seems to work. Testing again...

bonh commented 2 years ago

Nice work, looks good