search

uw-echospace / group-website

Website for Echospace Group at UW
https://uw-echospace.github.io/
MIT License
1 stars 22 forks source link

Add adkris1002 page #28

Closed aditya-uw closed 2 years ago

aditya-uw commented 2 years ago

@leewujung I have made my web page and I am tagging you to merge my branch! Take a look and let me know by Slack if I need to change anything :)

github-actions[bot] commented 2 years ago

🚀 Deployed on https://deploy-preview-28--uw-echospace.netlify.app

leewujung commented 2 years ago

@Adkris1002 : thanks for the PR! I've made a few suggestions and you should have gotten the email notifications.

This procedure is also meant to be a way to make sure you're familiar with the GitHub PR workflow for coding collaboratively, so I won't be using slack here. :)

I also noticed that you used "Add file via upload" to put info to your fork. If you haven't used git local vs remote setup, I would strongly recommend that you practice that in this PR (i.e., you will be pushing up your commit from a local command line or desktop app interface instead of adding file or editing directly on web browser).

aditya-uw commented 2 years ago

@leewujung Thank you for all the feedback! I have started to now use the command line to add-commit-push, I believe I resolved all your suggestions but feel free to take a look again!

leewujung commented 2 years ago

Looks great! I made a small grammar suggestion and otherwise this is ready to be merged. :)

aditya-uw commented 2 years ago

Totally missed that typo! Thank you!

leewujung commented 2 years ago

Great, thanks for making the changes. Merging now 🚀