search

uw-ictd / colte

Community LTE Project
MIT License
59 stars 27 forks source link

python: Remove coltedb dependency on psycopg2 #113

Closed matt9j closed 2 years ago

matt9j commented 2 years ago

psycopg2 is only needed when communicating with postgres, which should only be required when using the metering functionality. The base install should not require a database connection. Before this commit the base coltedb wrapper was creating a database connection and then passing it into the different implementation functions. This meant the database connection library was required, even if the connection was never needed. This commit moves the connection creation into each prepaid billing function.

This does result in a lot of duplication, and in-general the organization of the coltedb base script and the specialization scripts could be improved a lot.

matt9j commented 2 years ago

Build is likely failing due to this upstream change in github actions: https://github.com/actions/virtual-environments/issues/4797 Will require an update to the install workflow in the action.