search

uw-ictd / colte

Community LTE Project
MIT License
59 stars 27 forks source link

Update colteconf to generate configuration for Open5GS 2.7.0 #131

Closed mepholic closed 7 months ago

mepholic commented 7 months ago

These changes should cause colte to generate a config that is compatible with Open5GS 2.7.0

spencersevilla commented 7 months ago

Thanks for these changes!

Before I merge, I was wondering if you could speak a bit on why you're adding the create_if_not_exist logic. IMO colteconf should blow away any existing configs and setup something with only one MME, SMF, SGWC/U, etc. Or does this not actually do this and just add code robustness?

mepholic commented 7 months ago

Spencer, it looks to me as if colteconf is working on modifying the default configuration installed by open5gs. I agree with you that it should be generating configurations from scratch, but I had no desire to change its behavior in this commit. I reused preexisting code to coerce colteconf into modifying the configs in a manner consistent with the new open5gs 2.7.0 config format. I figured I should follow the pattern of what the code that existed before did.

spencersevilla commented 7 months ago

Sorry, I misread the code changes. Was trying to ask about some of the additional lines but now I understand how and why they're being used. Looks great to me and thanks for this work!