search

uw-ictd / colte

Community LTE Project
MIT License
59 stars 27 forks source link

Render currently enabled services #56

Closed liang-jenny closed 4 years ago

liang-jenny commented 5 years ago

Adding ability to render currently enabled services to anyone on the network as defined in a local JSON file (/usr/local/etc/colte/services.json). Network admins can update this file so users can access local services.

spencersevilla commented 4 years ago

This looks great! A couple of requests before I merge:

1) Can you put a sample services.json file (maybe with google.com or some other generic service) in package/webgui, and edit the Makefile to copy it into the right place when we make a .deb package? Related request, also remove the sample comments at the top of services.js because we'll have a sample config file for people to work off of.

2) In the Makefile can you increase WEBGUI_VERSION to 0.9.12?

3) I think it's a good idea to have a sample services.json file that works, but we don't necessarily want to advertise these services by default. I think the best approach is to include the sample file, have ENABLED_SERVICES set to "" by default, and have a comment below with the correct path (so if someone wants to add free services they can easily see where the file is and how to modify it).

4) I'll ping David and Ravita and handle the Indonesian translation. :-)

Great work!

liang-jenny commented 4 years ago

@spencersevilla Thanks for the updates, I just pushed those changes that you suggested!