uw-ictd / open5gs

open5gs is an open source implementation of the Evolved Packet Core and 5GC supporting 3GPP Release 16. This repository is a maintenance and research fork of the main upstream open5gs/open5gs.
https://open5gs.org
GNU Affero General Public License v3.0
2 stars 0 forks source link

MME not handling Emergency Attach correctly #16

Open spencersevilla opened 4 years ago

spencersevilla commented 4 years ago

When a UE sends an Attach Request, the normal/expected values for "EPS Attach Type" in NAS message are 0x1 (EPS attach) or 0x2 (combined EPS/IMSI attach). Interestingly, our code does not appear to check this value and simply copies it into the "EPS Attach Result" field in the Attach Accept message. This logic works for those normal values above, but fails for request type 0x110 ("EPS Emergency Attach") in attach request, which maps to "Reserved" in attach response. When we send this Attach accept message, we then receive an EMM Status error.

Copying the value when we make the attach accept could make sense if we write in different path-handling for Emergency Attach. We need to read the 3GPP and figure out how to handle these emergency attach messages, since this is important. I don't think we want to (or can) handle emergency calls so we should probably respond with an Attach Reject or something along those lines.

Refs:

spencersevilla commented 4 years ago

@pathiratk I think this would be a great one to focus on :-)