search

uw-ipd / tmol

TMol
Apache License 2.0
31 stars 3 forks source link

Fix error in the 4x4 identity matrix used in HT-based kinematics #239

Closed aleaverfay closed 3 years ago

aleaverfay commented 3 years ago

Two keystroke bugfix for long-standing, hard-to-find bug in the kinematics layer.

codecov[bot] commented 3 years ago

Codecov Report

Merging #239 (0cd2953) into master (b90fa0a) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files         227      227           
  Lines       11490    11490           
=======================================
  Hits        10699    10699           
  Misses        791      791
Flag Coverage Δ
_shrug_Testing_CPU 88.69% <ø> (ø)
_shrug_Testing_CPU_w_o_jit 89.27% <ø> (ø)
_shrug_Testing_CUDA 91.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b90fa0a...0cd2953. Read the comment docs.

aleaverfay commented 3 years ago

I don't understand why requesting a review from one of you, @fdimaio, @milkshakeiii, it removes the request for review from the other one. In any case, can someone look at this and give it a thumbs up?