uw-ipd / tmol

TMol
Apache License 2.0
30 stars 3 forks source link

Fix an out-of-bounds read in LKBall #266

Closed aleaverfay closed 1 year ago

aleaverfay commented 1 year ago

I mistook the dimension ordering in the backward pass for lk-ball. I discovered this by adding boundary assertions to TensorAccessor.h and then doing a lot of printf debugging.

We really need a way to conditionally compile in boundary-check statements into one of the unit test executions, e.g. the cpu-only version.