Closed jflat06 closed 11 months ago
I've cleaned up most of the code and added some of the requests from the cartbonded PR to this one as well.
... which actually let me find a bug on the jagged test in cuda:
E RuntimeError: CUDA error: an illegal memory access was encountered
E CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
E For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
I'll be working on debugging this next. Hopefully something obvious.
Edit: Fixed now.
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
b8940ef
) 95.13% compared to head (353bcbe
) 95.22%. Report is 1 commits behind head on master.:exclamation: Current head 353bcbe differs from pull request most recent head 532fb08. Consider uploading reports for the commit 532fb08 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
A rework of dunbrack to the res-centric scheme.
This still uses the DunbrackParamResolver, though portions of it to annotate the block types.
In the C++, it compresses everything down into a single kernel launch per residue.