uw-ipd / tmol

TMol
Apache License 2.0
30 stars 3 forks source link

Return dictionary instead of tuple from canonical_form_from_pose_stack #301

Closed aleaverfay closed 2 months ago

aleaverfay commented 2 months ago

The proper "canonical form" is a dictionary of the arguments that are input into pose_stack_from_canonical_form and thus a dictionary should be returned from the function in pose_stack_deconstrction.py that turns a pose_stack into a canonical form.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.72%. Comparing base (2cc46cd) to head (e5b945c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #301 +/- ## ======================================= Coverage 94.71% 94.72% ======================================= Files 299 299 Lines 20415 20420 +5 ======================================= + Hits 19337 19342 +5 Misses 1078 1078 ``` | [Flag](https://app.codecov.io/gh/uw-ipd/tmol/pull/301/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uw-ipd) | Coverage Δ | | |---|---|---| | [_shrug_Testing_CPU](https://app.codecov.io/gh/uw-ipd/tmol/pull/301/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uw-ipd) | `89.92% <100.00%> (+<0.01%)` | :arrow_up: | | [_shrug_Testing_CPU_debug_w_o_jit](https://app.codecov.io/gh/uw-ipd/tmol/pull/301/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uw-ipd) | `92.17% <100.00%> (+<0.01%)` | :arrow_up: | | [_shrug_Testing_CUDA](https://app.codecov.io/gh/uw-ipd/tmol/pull/301/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uw-ipd) | `92.45% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uw-ipd#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.