Make proximo-server a library

uw-labs / proximo

Interoperable GRPC based publish/subscribe

GNU Lesser General Public License v3.0

41 stars 16 forks source link

Make proximo-server a library #12

Closed thesyncim closed 5 years ago

thesyncim commented 6 years ago

hi nice project!

I would be nice to turn the server into a library and export "handler" interface so new Backends can be added without hacking.

mjgarton commented 6 years ago

Thanks for the contribution.

Can you explain further what you mean by "hacking" here please?

Looking at this another way, previous backends have been added in the past without a problem. What problem does this solve?

thesyncim commented 6 years ago

I mean that i need to clone this repo and edit the content of proximo-server in order to add a new backend. With this PR you can just import and implement Handler interface.

SpeedyCoder commented 5 years ago

this has been done in https://github.com/uw-labs/proximo/pull/73