search

uw-labs / proximo

Interoperable GRPC based publish/subscribe
GNU Lesser General Public License v3.0
41 stars 16 forks source link

adds nats streaming connection timeout #67

Closed thinktainer closed 5 years ago

SpeedyCoder commented 5 years ago

Looks good 👍 It would be nice to add this to substrate as well, as ultimately we would like to use substrate as proximo backend and so therefore only have one place where we have to deal with different streaming services...

thinktainer commented 5 years ago

this is step one for getting it into substrate.

thinktainer commented 5 years ago

@SpeedyCoder if all OK, i'll prepare the pr for substrate then.

mjgarton commented 5 years ago

I am wondering what state the connection is in when we get a disconnect notification? Do we still need to close the connection to clean up resources?

SpeedyCoder commented 5 years ago

@thinktainer it can still go in, as the move to substrate will take some time

thinktainer commented 5 years ago

I am wondering what state the connection is in when we get a disconnect notification? Do we still need to close the connection to clean up resources?

I do not know. Do you think it is important enough to investigate, before proceeding with this?

thinktainer commented 5 years ago

If there's no more concerns from @mjgarton I'll merge in the next hour.