search

uw-labs / proximo

Interoperable GRPC based publish/subscribe
GNU Lesser General Public License v3.0
41 stars 16 forks source link

Add acl support #89

Closed simonhdickson closed 3 years ago

simonhdickson commented 3 years ago

Adds support for ACL (bearer password, access rights, roles)

SpeedyCoder commented 3 years ago

Looks good, but I think it would be nicer to have this as one of the packages in the backend directory. That way people running customised proximo servers will be able to use it as well. In that case I would probably split the factory type into two, just to make things a bit cleaner and to match the other backends.

SpeedyCoder commented 3 years ago

It would be good to add doc string comments to public structs and functions and add some tests as well.

jakekeeys commented 3 years ago

great stuff, some example config in the readme would go down a treat