search

uw-pluverse / perses

language-agnostic program reducer.
GNU General Public License v3.0
168 stars 24 forks source link

Add JavaScript support. #17

Closed vincedani closed 2 years ago

vincedani commented 3 years ago

Dear Maintainers,

The pull request contains an extension with basic JavaScript language support.

Also contains one unresolved TODO section here.

chengniansun commented 3 years ago

Hi Daniel,

Thank you for your PR. I will review it as soon as possible. Currently I am facing several difficulties merging your PRs, mostly from my side.

  1. This is a mirror of our internal repo, and we periodically push our internal changes to this repo. I have not thought about how to merge public PRs into our internal repo.
  2. I am very busy this term on teaching, and have limited time on programming. I should be able to have more time after April.

Meanwhile, regarding your PR,

  1. Can you run ./scripts/presubmit.sh to clean up your PRs.
  2. Can you add tests to your code? One system test case in here, and several unit tests for the code that you changed.

Thanks.

chengniansun commented 3 years ago

Just want to update you about an issue in the PNF normalizer.

I tried to include the javascript grammar into Perses, however, the PNFied grammar was rejected by Antlr due to left recursions. This bug will take a while to fix.

vincedani commented 3 years ago

Hi @chengniansun,

Thanks for the suggestions, I'll update the PR soon with the results from ./scripts/presubmit.sh and the tests.

chengniansun commented 2 years ago

Thanks, @vincedani for your contribution.

Due to our current release workflow, we could not take external contributions for now. I hope we can fully migrate to this public repo by the end of this year.

If you have any problem or feature request about perses, please do not hesitage to open an issue.

Best. Chengnian.