The src/noisepy/seis/noise_module.py module uses print() statements for logging, which is less than ideal. A better alternative is to use python's standard logging package.
This change has already been done in `src/noisepy/seis/S1_fft_cc_MPI.py, which can be used as a reference.
Steps:
Create a logger instance at the top of the file: logger = logging.getLogger(__name__)
Replace all print() calls with calls to logger.info(), logger.debug(), logger.error() or logger.warning(). Use your best judgement from the code context to decide the type of logging. We can also discuss during the pull request review.
nrich20
commented
1 year ago
Contact
carlosg@uw.edu
Description
The
src/noisepy/seis/noise_module.pymodule usesprint()statements for logging, which is less than ideal. A better alternative is to use python's standard logging package.This change has already been done in `src/noisepy/seis/S1_fft_cc_MPI.py, which can be used as a reference.
Steps:
logger = logging.getLogger(__name__)print()calls with calls tologger.info(), logger.debug(), logger.error() or logger.warning(). Use your best judgement from the code context to decide the type of logging. We can also discuss during the pull request review.Code Repository
https://github.com/mdenolle/NoisePy
Issue link
No response
Task level
L1
What is the primary programming language for the task
python
Additional dependencies
No response