uw-ssec / codeuw

Repository of resources and tasks for contributing to scientific software projects
4 stars 4 forks source link

[Code UW]: Offshore Geodesy - Add test case to raise ValueError #23

Closed lsetiawan closed 1 year ago

lsetiawan commented 1 year ago

Contact

landungs@uw.edu

Description

The gnatss package has a module called harmonic_mean. This module calculates the harmonic mean of a sound speed profile. The function that is used for the user is called sv_harmonic_mean. Based on code coverage analysis in codecov The ValueError is not covered. Additionally, there's a private function called _compute_hm that also has ValueError that is not covered.

The task is to do the following:

Code Repository

https://github.com/uw-ssec/offshore-geodesy

Issue link

No response

Task level

L1

What is the primary programming language for the task

python

Additional dependencies

No response

lsetiawan commented 1 year ago

Addressed in https://github.com/uw-ssec/offshore-geodesy/pull/103