search

uwasystemhealth / IndEAAv2

A web application that streamlines course review by industry advisory panels. A complete rewrite of https://github.com/uwasystemhealth/IndEAA
4 stars 1 forks source link

[BUG] Visual bug Google login redirect briefly shows error 500 #69

Open peter-tanner opened 2 years ago

peter-tanner commented 2 years ago

Describe the bug

An error code is shown when logging on in the bottom right corner. This is only meant to show when login is unsuccessful, but every time error 500 is shown briefly regardless of whether the login failed.

To Reproduce

Steps to reproduce the behavior:

  1. Login as normal
  2. After being redirected back from Google, an error code will briefly show in the bottom right.

Expected behavior

Error only shows when login failed

Other

Screenshots If applicable, add screenshots to help explain your problem.

Additional context I think this is due to a second react render occurring, which sends the login token twice. The first time this succeeds but the same token is sent a second time resulting in the error.

frinzekt commented 2 years ago

You seem to be correct about that... Notice this https://sentry.io/organizations/uwa-system-health-lab/issues/3527123937/?project=6667527&query=is%3Aunresolved

there's an alert of 500 coming from the server because of it

frinzekt commented 2 years ago

I have first encountered it sometime in #61 ... i would have thought it would fix it