uwasystemhealth / IndEAAv2

A web application that streamlines course review by industry advisory panels. A complete rewrite of https://github.com/uwasystemhealth/IndEAA
4 stars 1 forks source link

Investigate Iframe for Document View - Allowing a reviewer to view document within the app instead of opening in another tab #95

Open frinzekt opened 2 years ago

frinzekt commented 2 years ago

What needs to be done?

Investigate iframe for use in Document viewing. This task needs to consider 3 aspects

Other

While doing #16, I wondered if it will be good for the reviewer to view the document within the app instead of opening a new tab.

Below is the proof of concept (you can see this in a branch called iframe-experiment image

However, I am unsure how much iframes are supported. At first when I tried displaying a pdf from google using share link, it displayed "403 forbidden". Further search showed this https://stackoverflow.com/questions/44164367/how-to-embed-google-drive-document-pdf-in-blogger-post (which makes it possible to display PDF using "embed item"). This however adds extra steps to the user.