uwblueprint / supportive-housing

🏘️ Supportive Housing Of Waterloo location management platform
6 stars 0 forks source link

Tags Default Sort By Last Modified #204

Closed carolynzhang18 closed 11 months ago

carolynzhang18 commented 11 months ago

Notion task link

Tags Default Sort By Last Modified

Implementation description

Steps to test

  1. Upgrade database to latest migration: bash ./scripts/flask-db-upgrade.sh
  2. In order to test these routes with Postman, first comment out @require_authorization_by_role({"Admin"})
on lines 10, 24, 47, and 71 of backend/app/rest/tags_routes.py.
  3. Create a few tags by POSTing to /tags/ (e.g. {"name": “Cool Tag”, "status": "Active”}).
  4. Try GETting from /tags/. The tags you added should be returned in reverse chronological order.
  5. Update a tag by PUTting to /tags/[id] (e.g. {"name": “Edited Tag”, "status": "Active”}).
  6. Try GETting from /tags/. The tag you just updated should be the first one returned (and the rest of the tags should also be returned in reverse chronological order).
  7. Create & update a few more tags, and check that GETting them still results in the expected order.

What should reviewers focus on?

Checklist

github-actions[bot] commented 11 months ago

Visit the preview URL for this PR (updated for commit 25c3243):

https://blueprintsupportivehousing--pr204-carolyn-tags-sort-la-de1sljqy.web.app

(expires Thu, 30 Nov 2023 01:13:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09

achandrabalan commented 11 months ago

LGTM 🥇 Creating / Updating tags rearranges as expected.