search

uwburn / cardia

Heart rate monitoring client for gamers
GNU General Public License v3.0
86 stars 23 forks source link

upgrade target framework and added view setting #53

Closed ccpu closed 2 weeks ago

ccpu commented 3 weeks ago

cardia

uwburn commented 2 weeks ago

Hello, and thanks for the contribution.

Unfortunately i had to reinstall Windows recently and i don't have Visual Studio installed anymore, as i moved on other technological stacks since i worked on Cardia. Therefore, at the moment, i cannot perform a proper review of the changes introduced.

Taking a quick glance on the changes, i do see that there 400+ files changed and an astonishing +1,333,129/-238 changes, with many libraries added for which, to me, it is not clear the purpose. While the feature added is interesting, i cannot accept a PR of this extent with so many changes unrelated to the core addition.