search

uwcms / FinalStateAnalysis

An analysis framework for the Compact Muon Solenoid
3 stars 43 forks source link

recipe_42x.sh #235

Closed isobelojalvo closed 11 years ago

isobelojalvo commented 11 years ago

Hi @lgray
I'm trying to set up 42x and run into this issue when I try to compile:

/afs/hep.wisc.edu/cms/ojalvo/pattuple42X/CMSSW_4_2_8_patch7/src/FinalStateAnalysis/DataAlgos/src/PhotonParentage.cc:60: error: ISO C++ forbids declaration of 'lp' with no type

It seems there is some compatibility issue? Can you fix it? I'd really like to produce my 42X pattuples over the weekend.

Cheers, Isobel

lgray commented 11 years ago

Hi Isobel,

This is a gcc compatibility issue, it works in CMSSW_5 and above.

Everywhere you see "auto" in PhotonParentage.cc you can replace it with "std::vectorreco::GenParticleRef::const_iterator". This will fix the problem.

Best, -Lindsey

On Fri, Jul 5, 2013 at 7:37 PM, isobelojalvo notifications@github.comwrote:

Hi @lgray https://github.com/lgray

I'm trying to set up 42x and run into this issue when I try to compile:

/afs/ hep.wisc.edu/cms/ojalvo/pattuple42X/CMSSW_4_2_8_patch7/src/FinalStateAnalysis/DataAlgos/src/PhotonParentage.cc:60: error: ISO C++ forbids declaration of 'lp' with no type

It seems there is some compatibility issue? Can you fix it? I'd really like to produce my 42X pattuples over the weekend.

Cheers, Isobel

— Reply to this email directly or view it on GitHubhttps://github.com/uwcms/FinalStateAnalysis/issues/235 .

isobelojalvo commented 11 years ago

Ok, on to the next issue: /FinalStateAnalysis/PatTools/plugins/PATElectronCutBasedIdEmbedder.cc:26:70: error: EGamma/EGammaAnalysisTools/interface/EGammaCutBasedEleId.h: No such file or directory

lgray commented 11 years ago

Probably someone forgot to update that when FSA was updated to use more recent EGM recipes, something recent by Austin I think. The file appears to have moved. I have no clue where it is and I haven't touched FSA in some months now. I am not the best person to ask about this.

Austin or Evan will know.

-Lindsey

On Fri, Jul 5, 2013 at 7:58 PM, isobelojalvo notifications@github.comwrote:

Ok, on to the next issue: /FinalStateAnalysis/PatTools/plugins/PATElectronCutBasedIdEmbedder.cc:26:70: error: EGamma/EGammaAnalysisTools/interface/EGammaCutBasedEleId.h: No such file or directory

— Reply to this email directly or view it on GitHubhttps://github.com/uwcms/FinalStateAnalysis/issues/235#issuecomment-20531500 .

isobelojalvo commented 11 years ago

I pinged @ekfriis via email. If you have a chance and could look into it it'd be awesome! I am planning on only needing it one more time.

mcepeda commented 11 years ago

Hi Lindsey,

Looking at the age of the files (the recipe edited 5 months ago, the file that breaks 7 months ago), I think this is not something recent.

It looks like something went wrong when installing the recipe (EgammaAnalysisTools was for whatever reason not downloaded from CVS).

I am also going to try from scratch to see what can be happening.

Maria

jjswan33 commented 11 years ago

Hi Isobel. You could safely check out an older recipe I think for 42X.

ekfriis commented 11 years ago

Yes, if all you need is PAT tuples (but not latest recipe) you can do:

cd FinalStateAnalysis
git checkout hcp2012

and rerun the recipe. (Delete all the other packages in your area before you run it)

On Fri, Jul 5, 2013 at 11:25 AM, jjswan33 notifications@github.com wrote:

Hi Isobel. You could safely check out an older recipe I think for 42X.

— Reply to this email directly or view it on GitHubhttps://github.com/uwcms/FinalStateAnalysis/issues/235#issuecomment-20532666 .

ekfriis commented 11 years ago

OK, so offline we discovered this isn't the right tag we want.

I think you want this commit:

5c1e6dacd17ab2ec85c5544d1d945a5aaa6c3299

mentioned by Ian in #147, which should correspond to the HEAD used in #150 and #149, which is what you guys are using.

So @isobelojalvo you should create a 428_patch7 area, and do:

cd FinalStateAnalysis
git checkout 5c1e6dacd17ab2ec85c5544d1d945a5aaa6c3299
# ignore error about detached head state
# run recipe.sh, etc

This should have the AntiElectronMVA3 + latest Tau ID.

In the future, @tsarangi should make a note of the commit hashed used when he submits PAT tuples in the corresponding issue (and I should give a specific one in the initial request), so we don't need to go fishing like this.

isobelojalvo commented 11 years ago

Ran into another issue: /afs/hep.wisc.edu/cms/ojalvo/pattuple42X/CMSSW_4_2_8_patch7/src/FinalStateAnalysis/PatTools/src/ElectronIDMVA.cc:2:69: error: FinalStateAnalysis/PatTools/interface/PATProductionFlag.h: No such file or directory gmake: *\ [tmp/slc5_amd64_gcc434/src/FinalStateAnalysis/PatTools/src/FinalStateAnalysisPatTools/ElectronIDMVA.o] Error 1

Found the old file and manuallly added it back in. It builds. Let me know if you think this will cause an unforseen issue.

ekfriis commented 11 years ago

As long as it builds it should be okay. This was a hacky feature that was prone to breaking that we have gotten rid of in the head.

On Sat, Jul 6, 2013 at 3:34 AM, isobelojalvo notifications@github.comwrote:

Ran into another issue: /afs/ hep.wisc.edu/cms/ojalvo/pattuple42X/CMSSW_4_2_8_patch7/src/FinalStateAnalysis/PatTools/src/ElectronIDMVA.cc:2:69: error: FinalStateAnalysis/PatTools/interface/PATProductionFlag.h: No such file or directory gmake: *** [tmp/slc5_amd64_gcc434/src/FinalStateAnalysis/PatTools/src/FinalStateAnalysisPatTools/ElectronIDMVA.o] Error 1

Found the old file and manuallly added it back in. It builds. Let me know if you think this will cause an unforseen issue.

— Reply to this email directly or view it on GitHubhttps://github.com/uwcms/FinalStateAnalysis/issues/235#issuecomment-20552458 .

ekfriis commented 11 years ago

If you are still having problems I strongly suggesting starting from scratch in a new area. Running recipe.sh multiple times can be problematic - most of these issues are now fixed, but I'm not sure which ones are there in the version you are using.

isobelojalvo commented 11 years ago

I sent you an email as well.... This does not run. Can you try setting it up?

ekfriis commented 11 years ago

Did you try to set everything up from scratch?

On Sat, Jul 6, 2013 at 9:28 AM, isobelojalvo notifications@github.comwrote:

I sent you an email as well.... This does not run. Can you try setting it up?

— Reply to this email directly or view it on GitHubhttps://github.com/uwcms/FinalStateAnalysis/issues/235#issuecomment-20556830 .

isobelojalvo commented 11 years ago

was it supposed to be recipe.sh or recipe_42X.sh

ekfriis commented 11 years ago

PATPROD=1 LUMI=1 LIMITS=1 ./recipe.sh

On Sat, Jul 6, 2013 at 10:11 AM, isobelojalvo notifications@github.comwrote:

was it supposed to be recipe.sh or recipe_42X.sh

— Reply to this email directly or view it on GitHubhttps://github.com/uwcms/FinalStateAnalysis/issues/235#issuecomment-20557507 .

isobelojalvo commented 11 years ago

Missing files from this recipe... Looking for them on CVS.

/afs/hep.wisc.edu/cms/ojalvo/pattuple42X2/CMSSW_4_2_8_patch7/src/FinalStateAnalysis/PatTools/plugins/PATJetPUIDEmbedder.cc:26:65: error: RecoJets/JetProducers/interface/PileupJetIdentifier.h: No such file or directory /afs/hep.wisc.edu/cms/ojalvo/pattuple42X2/CMSSW_4_2_8_patch7/src/FinalStateAnalysis/PatTools/plugins/PATElectronCutBasedIdEmbedder.cc:26:70: error: EGamma/EGammaAnalysisTools/interface/EGammaCutBasedEleId.h: No such file or directory /afs/hep.wisc.edu/cms/ojalvo/pattuple42X2/CMSSW_4_2_8_patch7/src/FinalStateAnalysis/PatTools/plugins/PATJetPUIDEmbedder.cc: In member function 'virtual void PATJetPUIDEmbedder::produce(edm::Event&, const edm::EventSetup&)': /afs/hep.wisc.edu/cms/ojalvo/pattuple42X2/CMSSW_4_2_8_patch7/src/FinalStateAnalysis/PatTools/plugins/PATJetPUIDEmbedder.cc:91: error: 'PileupJetIdentifier' has not been declared /afs/hep.wisc.edu/cms/ojalvo/pattuple42X2/CMSSW_4_2_8_patch7/src/FinalStateAnalysis/PatTools/plugins/PATJetPUIDEmbedder.cc:92: error: 'PileupJetIdentifier' has not been declared

isobelojalvo commented 11 years ago

Ok this one seems to work: commit 09341d9ba275a4c6ad061bcf57980689e33333e1 Author: Evan K. Friis ekfriis@gmail.com Date: Wed Mar 6 16:37:27 2013 +0100

With these tags (I did not check these out with the conventional method so it's probably necessary to see if the committed recipe does work): B4_2_X_V00-03-05 CommonTools/ParticleFlow
NoTag CommonTools/RecoAlgos
V00-04-00 CondFormats/EgammaObjects
V05-00-16 DataFormats/JetReco
V03-03-18 DataFormats/METReco
V06-04-19-05 DataFormats/PatCandidates
CMSSW_5_2_4 DataFormats/TauReco
V00-00-30-BP42X EGamma/EGammaAnalysisTools
HCP2012_V04-44X EgammaAnalysis/ElectronTools
V01-13-02 HiggsAnalysis/CombinedLimit
METPU_4_2_X_v2 JetMETCorrections/METPUSubtraction
V11-03-16 PhysicsTools/HepMCCandAlgos
V08-06-58 PhysicsTools/PatAlgos
V03-09-18 PhysicsTools/PatUtils
V00-03-24 PhysicsTools/SelectorUtils
V08-02-14 PhysicsTools/UtilAlgos
CMSSW_4_2_8_patch7 RecoEgamma/EgammaElectronAlgos
CMSSW_5_2_2 RecoEgamma/EgammaIsolationAlgos
V08-11-10-02 RecoEgamma/EgammaTools
METPU_5_3_X_v3 RecoJets/JetProducers
V04-01-09 RecoLuminosity/LumiDB
NoTag RecoMET/METAlgorithms
V01-04-10-4XX RecoTauTag/Configuration
V01-04-23-4XX-00 RecoTauTag/RecoTau
CMSSW_5_2_4 RecoTauTag/TauTagTools

ekfriis commented 11 years ago

Awesome - hope it works! Heading to airport now, see you on Monday!

On Sat, Jul 6, 2013 at 2:24 PM, isobelojalvo notifications@github.comwrote:

Ok this one seems to work: commit 09341d9https://github.com/uwcms/FinalStateAnalysis/commit/09341d9ba275a4c6ad061bcf57980689e33333e1 Author: Evan K. Friis ekfriis@gmail.com Date: Wed Mar 6 16:37:27 2013 +0100

With these tags (I did not check these out with the conventional method so it's probably necessary to see if the committed recipe does work): B4_2_X_V00-03-05 CommonTools/ParticleFlow

NoTag CommonTools/RecoAlgos

V00-04-00 CondFormats/EgammaObjects

V05-00-16 DataFormats/JetReco

V03-03-18 DataFormats/METReco

V06-04-19-05 DataFormats/PatCandidates

CMSSW_5_2_4 DataFormats/TauReco

V00-00-30-BP42X EGamma/EGammaAnalysisTools

HCP2012_V04-44X EgammaAnalysis/ElectronTools

V01-13-02 HiggsAnalysis/CombinedLimit

METPU_4_2_X_v2 JetMETCorrections/METPUSubtraction

V11-03-16 PhysicsTools/HepMCCandAlgos

V08-06-58 PhysicsTools/PatAlgos

V03-09-18 PhysicsTools/PatUtils

V00-03-24 PhysicsTools/SelectorUtils

V08-02-14 PhysicsTools/UtilAlgos

CMSSW_4_2_8_patch7 RecoEgamma/EgammaElectronAlgos

CMSSW_5_2_2 RecoEgamma/EgammaIsolationAlgos

V08-11-10-02 RecoEgamma/EgammaTools

METPU_5_3_X_v3 RecoJets/JetProducers

V04-01-09 RecoLuminosity/LumiDB

NoTag RecoMET/METAlgorithms

V01-04-10-4XX RecoTauTag/Configuration

V01-04-23-4XX-00 RecoTauTag/RecoTau

CMSSW_5_2_4 RecoTauTag/TauTagTools

— Reply to this email directly or view it on GitHubhttps://github.com/uwcms/FinalStateAnalysis/issues/235#issuecomment-20561339 .

ekfriis commented 11 years ago

Hi @isobelojalvo, do you know if it worked? Can I close this? I have created a separate issue #236 to deal with updating the current HEAD.

isobelojalvo commented 11 years ago

Ok, more to add now. To actually run on the 42x pattuples I needed this recipe (obviously tau specific). I was continually getting segfaults when running over electrons and I believe it is due to the different versions in the dataformat/electron. i.e. the 7TeV 42x pattuples WILL NOT RUN without this pat recipe! (ignore the non-pat stuff if you don't need it).

what you need for running 7TeV Pattuples

addpkg DataFormats/PatCandidates V06-04-19-05 cvs up -r 1.44 DataFormats/PatCandidates/interface/Electron.h cvs up -r 1.33 DataFormats/PatCandidates/src/Electron.cc addpkg PhysicsTools/PatAlgos V08-06-58 addpkg PhysicsTools/PatUtils V03-09-18 addpkg CommonTools/ParticleFlow B4_2_X_V00-03-05 addpkg PhysicsTools/SelectorUtils V00-03-24 addpkg PhysicsTools/UtilAlgos V08-02-14 rm -f PhysicsTools/PatAlgos/plugins/PATMHTProducer*

other stuff for UWAnalysis Taus

cvs co -r V01-13-02 HiggsAnalysis/CombinedLimit cvs co -r V01-13-02 HiggsAnalysis/HiggsToTauTau cvs co -r V11-03-16 PhysicsTools/HepMCCandAlgos cvs co -r bMinimalSVfit-08-03-11 AnalysisDataFormats/TauAnalysis cvs co -r V00-02-03s TauAnalysis/CandidateTools cvs co -r V08-03-15 PhysicsTools/Utilities

mvamet (ignore if not needed)

cvs co -r METPU_4_2_X_v2 JetMETCorrections/METPUSubtraction cd JetMETCorrections/METPUSubtraction/test/ ./setup42.sh cd ../../../

cp /afs/cern.ch/user/a/agilbert/public/CMSSW_Setup/PileupJetID_cfi.py RecoJets/JetProducers/python/ cp /afs/cern.ch/user/a/agilbert/public/CMSSW_Setup/pujetidsequence_cff.py RecoJets/JetProducers/python/ touch RecoJets/JetProducers/data/dummy.txt cvs co -r CMSSW_4_2_8_patch7 RecoMET/METAlgorithms/interface/SigInputObj.h cvs co -r CMSSW_4_2_8_patch7 RecoMET/METAlgorithms/src/SigInputObj.cc addpkg DataFormats/TauReco CMSSW_5_2_4 # yes, this is correct
addpkg RecoTauTag/TauTagTools CMSSW_5_2_4 cvs co -r V01-04-23-4XX-00 RecoTauTag/RecoTau cvs co -r V01-04-10-4XX RecoTauTag/Configuration cvs co -r V00-04-00 CondFormats/EgammaObjects cvs up -r 1.52.10.4 PhysicsTools/PatAlgos/python/tools/tauTools.py cvs co -r V04-01-03 RecoLuminosity/LumiDB
cvs up -C RecoTauTag/RecoTau

....And that was how I spent my weekend.....

isobelojalvo commented 11 years ago

Hi, After more weeks of debugging on this issue it seems the pile up jet id for this setup is incorrect. In particular this line:

cp /afs/cern.ch/user/a/agilbert/public/CMSSW_Setup/PileupJetID_cfi.py RecoJets/JetProducers/python/

Should not be followed. It causes you to run 8TeV pileup jet id.

Unfortunately, since we already have produced all these pattuples the simplest solution is to just rerun the jets and pile up jet id yourself.

Isobel