search

uwdb / Cosette

Cosette is an automated SQL solver.
BSD 2-Clause "Simplified" License
662 stars 54 forks source link

fixed Rosette installation in FrontendDockerfile #69

Closed primeapple closed 5 years ago

primeapple commented 5 years ago

As suggested I created a pull request. I tested the changes with the test_in_docker.sh file, they work correctly.

With the old file, failures occured.

A full explanation of the changes is found in #68

Please review and merge. Tell me your thoughts!

stechu commented 5 years ago

It appears that the travis-CI failed. Would you mind taking a look? If not, I can take a look later this week.

primeapple commented 5 years ago

Of course I will have a look :)

The problem is that the dockerimage for Cosette-Frontend is pulled from shumo/cosette-frontend (dockerhub). However this image is build with the exact wrong dockerfile, that I propose to fix in this PR.

We could solve this by merge this PR and update the dockerfile in shumo/cosette-frontend (see here) to the version that I created here :)

akcheung commented 5 years ago

Thanks @primeapple . I have merged your PR manually on my local repo and it passed the regression tests.

stechu commented 5 years ago

I see. That's the circular dependency issue (that file in docker hub actually linked here as well).

stechu commented 5 years ago

Restart CI test after new docker image is up. Now the CI test passes. Thanks @primeapple !