search

uwefladrich / rdy2cpl

A Python tool to create auxiliary files and remapping weights for the OASIS coupler
MIT License
3 stars 3 forks source link

Write OpenIFS grid cell fractions in oasis files #22

Open jmrgonza opened 1 year ago

jmrgonza commented 1 year ago

I think that it would make an improvement if rdy2cpl could write the grid cell land/water fraction (using the pyoasis set_frac method) into the grid definitions files, at least for the OpenIFS grid. This information can improve the coupling of some fields. For example runoff from the ILCL grid to the runoff mapper.

jmrgonza commented 11 months ago

I do not want to put pressure on this, but it would make it easier for me for the implementation of another project (a replacement of the runoff-mapper for ECE4), if it would be possible to get the effective fraction of land from the oasis files (instead of going to the initial conditions for that).

I saw that there is indeed a call to set_frac in https://github.com/uwefladrich/rdy2cpl/blob/b63655c48cd772a9ef2fe446255e928a8b2a0436/rdy2cpl/grids/couple_grid.py#L63 which is only executed if the fractions attribute is defined. I can make a proposal for this, at least for the OIFS grids.

jmrgonza commented 11 months ago

In pull request #26, I have proposed a modification that would allow to get the frc information just for the OIFS grid that has the ocean masked (used for the communication with runoff-mapper).

I am unsure about what should be the fraction of grid cells that should be active for the coupling with Nemo.