search

uweschaefer / wicket-modelfactory

API to create Wicket PropertyModels in a typesafe and refactoring-safe way
http://www.wicketeer.org/wicket-modelfactory/getting_started.html
Other
3 stars 1 forks source link

Regression when migrating from 0.9.3 to 0.9.7 #3

Closed tkruse closed 9 years ago

tkruse commented 9 years ago

When running our unit tests, we get:

java.lang.NoSuchMethodError: org.apache.wicket.request.cycle.RequestCycle.setMetaData(Lorg/apache/wicket/MetaDataKey;Ljava/lang/Object;)Lorg/apache/wicket/request/cycle/RequestCycle;
    at org.wicketeer.modelfactory.RequestCycleLocal.set(RequestCycleLocal.java:76)
    at org.wicketeer.modelfactory.RequestCycleLocalFrom.set(RequestCycleLocalFrom.java:57)
    at org.wicketeer.modelfactory.ModelFactory.from(ModelFactory.java:291)
    at accounts.AddressEditPanel.createStreetAndNumber(AddressEditPanel.java:80)

This exception looks dodgy, involving code paths that don't seem to have changed since 0.9.3, maybe jar was compiled differently?

tkruse commented 9 years ago

btw, cool that you are on github now. I notice you have no LICENSE file. This is recommended for github. I know there are file headers in the source indicating Apache License 2, but a LICENSE file is still nicer.

tkruse commented 9 years ago

0.9.4 also works, btw.

uweschaefer commented 9 years ago

thanks for reporting, will look into it.

uweschaefer commented 9 years ago

the only noticeable change was shifting the dependency to wicket-core from 6.0.0 to [6.0.0). i changed it temporarily to [6.0.0,7.0.0). could you please rerun, or (better share) your tests, so that i can reproduce this?

uweschaefer commented 9 years ago

License file added

tkruse commented 9 years ago

will try to reproduce tomorrow.

On Mon, Mar 16, 2015 at 10:49 PM, Uwe Schaefer notifications@github.com wrote:

License file added

— Reply to this email directly or view it on GitHub https://github.com/uweschaefer/wicket-modelfactory/issues/3#issuecomment-81956738 .

tkruse commented 9 years ago

The bug reproduced instantly with a new quickstart project:

git clone https://github.com/tkruse/modelfactory-bug
mvn test

I don't know what you mean with "i changed it temporarily to [6.0.0,7.0.0)" Does that mean I should build modelfactory from source and try again? Hopefully you can reproduce the bug using the quickstart yourself, would be easier.

uweschaefer commented 9 years ago

cool will look into it.

uweschaefer commented 9 years ago

Ok, stupid me.

using [6.0.0,7.0.0) still is too wide, because 7.0.0-M* is still part of this range. I changed it to 6.99 to express that wicket-modelfactory (in its current state) is only compatible with the 6.* branch of Wicket.

There will be a seperate release for Wicket7, and another on faciliating java8 lambdas over the hacky lambda4j that was necessary before.

thanks!

uweschaefer commented 9 years ago

0.9.8 is currently staging in maven central

jan-krakora commented 8 years ago

Hi @uweschaefer, it's quite a while since you closed this issue. Are you plannig to release the wicket-modelfactory for the Wicket 7 soon?

uweschaefer commented 8 years ago

very busy currently, expect something in march.