Add support for Wicket 7

uweschaefer / wicket-modelfactory

API to create Wicket PropertyModels in a typesafe and refactoring-safe way

http://www.wicketeer.org/wicket-modelfactory/getting_started.html

Other

3 stars 1 forks source link

Add support for Wicket 7 #6

Open jan-krakora opened 8 years ago

jan-krakora commented 8 years ago

Current modelfactory supports only Wicket 6. It would be nice to support the Wicket 7 also.

uweschaefer commented 8 years ago

willing to. would you mind contributing some unit test of how that should look like? also, is java8 requirement ok?

jan-krakora commented 8 years ago

The only change in Wicket 7 related to the model factory is that org.apache.wicket.request.cycle.RequestCycle.setMetaData() returns RequestCycle instead of void as in Wicket 6 and below. To support Wicket 7, the model factory just need to be compiled with the Wicket 7.

I would suggest to create two more branches apart from the master

One for Wicket 6
One for Wicket 7

In each branch you can set dependency on a proper Wicket version.

As for the java8, Wicket requires java7. So I think java8 is too restrictive. On the other hand, we use java8 in our company. So if you ask me - java8 is ok.

uweschaefer commented 8 years ago

thanks for the suggestions. i'll add a wicket7 branch the other day.

reiern70 commented 8 years ago

Can I help with this? Company I'm working for uses this project and migrating to wicket 7 is on their road map.

uweschaefer commented 8 years ago

i'd love that.

i created two branches (wickt6/7) waiting for pullreqs, where i think at least the wicket6-branch is unnecessary. i am still pondering, how to organize this (classifiers?). Any help much appreciated.

reiern70 commented 8 years ago

I have locally tested our application and everything seems to be OK: all tests pass (almost only one that is not related to wicket-modelfactory).

Would you consider moving this project to wicket-stuff? That way you don't have to take care of deploying new versions.

Cheers,

Ernesto

reiern70 commented 8 years ago

Would it be possible, at least, to push a new version of wicket 7 version to maven central?

mweirauch commented 8 years ago

Hi Uwe.

Houston we got a problem with wicket:6.x and wicket-modelfactory:0.9.13+.

Any artifact from 0.9.13 onwards is apparently built against Wicket 7 leading to the RequestCycle#setMetaData() stuff issue above.

java.lang.NoSuchMethodError: org.apache.wicket.request.cycle.RequestCycle.setMetaData(Lorg/apache/wicket/MetaDataKey;Ljava/lang/Object;)Lorg/apache/wicket/request/cycle/RequestCycle;

For completeness sake:

6.24.0:
public final <T> void setMetaData(final MetaDataKey<T> key, final T object)

7.4.0:
public final <T> RequestCycle setMetaData(final MetaDataKey<T> key, final T object)

Mixing the wicket major versions is apparently no good. I assume the ABI issues (dunno if this is the right term in JAVA) are the reason for wicket-stuff and wicket-bootstrap keeping two branches as well.

uweschaefer commented 8 years ago

i'll take a look on the weekend

uweschaefer commented 8 years ago

i released two versions 6.9.16 and 7.9.16

for the latest major releases of wicket respectivly. i do not close this issue due to documentation update is still pending.

mweirauch commented 8 years ago

Works :)

But either github is playing tricks on me or the artifcat versions between the wicket6 and wicket7 branches are mixed up.

uweschaefer commented 8 years ago

stupid me, will release next in a few min...

mweirauch commented 8 years ago

Or just rename the branches. ;) The 6.9.16 release is ok regarding it's dependencies. (uses wicket 6.24)

wicket6 carries 7.9.17-SNAPSHOT and wicket7 carries 6.9.17-SNAPSHOT

uweschaefer commented 8 years ago

grin ... should be fixed now - .9.17 it is...

elijah commented 7 months ago

Please get lost with your scamming.