search

uwescience / myria-web

Web frontend for Myria
https://demo.myria.cs.washington.edu
Other
11 stars 14 forks source link

Show an alert when the cluster is reserved for experiments. Fixes #186 #215

Closed domoritz closed 9 years ago

domoritz commented 9 years ago

screen shot 2014-11-12 at 16 19 20

dhalperi commented 9 years ago

This is pretty cool, great work!

I think the use of timeago makes it less useful. I would say we should have two or three different behaviors and should have explicit messages and colors that differentiate them.

  1. if the cluster is currently reserved. The user needs to know "please do not use it now" and also needs to know when it will be free again. "Alert: The Myria cluster is currently being used for research experiments. It will be available again [on 2014-11-14 at 5am PDT]."
  2. the cluster will be reserved soon (next 6 hours). "Warning: Very shortly, the Myria cluster will be reserved for research experiments, beginning [on 2014-11-12 at 7pm PDT]. Please only submit queries that will finish well before that time."
  3. there is an upcoming reservation (next 2 days). "Notice: There is an upcoming reservation for the cluster for research experiments, beginning [on 2014-11-13 at 7pm PDT]."

In any of these three cases, include the link to the calendar.

Maybe use different colors (red, yellow, green) for the three alerts?

domoritz commented 9 years ago

I was surprised to see an API key at all as the calendar is public... but I can imagine that it's needed.

Presumably, this is some throwaway key for which it's okay if it is copied and used for a different application? (Or this is disallowed by Google?)

We can trow it away at any time and also limit where is is valid (which requesting url). I'll do that as soon as we deployed.

domoritz commented 9 years ago

All done!

dhalperi commented 9 years ago

Thanks!!

dhalperi commented 9 years ago

(Travis-CI is having an issue right now, but the tests pass.)

domoritz commented 9 years ago

Cause we don't have tests for the front end anyway. On Nov 12, 2014 6:41 PM, "Daniel Halperin" notifications@github.com wrote:

(Travis-CI is having an issue right now, but the tests pass.)

— Reply to this email directly or view it on GitHub https://github.com/uwescience/myria-web/pull/215#issuecomment-62832227.

dhalperi commented 9 years ago

we test that the page loads without errors, which has actually saved our bacon quite a lot. But yes, we don't test well :).

stechu commented 9 years ago

That's awesome. Thanks, Dominik!