search

uwescience / myria-web

Web frontend for Myria
https://demo.myria.cs.washington.edu
Other
11 stars 14 forks source link

Highlight no tuples, show num tuples in tooltip #231

Closed domoritz closed 9 years ago

domoritz commented 9 years ago

See #226

dhalperi commented 9 years ago

I don't understand the tooltip. How is this screenshot correct?

screen shot 2014-12-08 at 6 58 35 pm

http://localhost:8089/profile?queryId=46220

dhalperi commented 9 years ago

Even taking the average number of tuples per cell (50862578/72.0/72.0), I get 9811 tuples.

dhalperi commented 9 years ago

Ahhh, it looks like the tooltip is getting the scaled [2, 6] value of the number of tuples, rather than the actual number of tuples. https://github.com/uwescience/myria-web/blob/viz-improvements-3/appengine/js/graph.js#L201

Presumably, that's not what you want.

domoritz commented 9 years ago

Ups... I shouldn't have coded during the meeting, while I was distracted... On Dec 8, 2014 7:12 PM, "Daniel Halperin" notifications@github.com wrote:

Ahhh, it looks like the tooltip is getting the scaled [2, 6] value of the number of tuples, rather than the actual number of tuples. https://github.com/uwescience/myria-web/blob/viz-improvements-3/appengine/js/graph.js#L201

— Reply to this email directly or view it on GitHub https://github.com/uwescience/myria-web/pull/231#issuecomment-66228522.

domoritz commented 9 years ago

Duh, that was embarrassing code. I'm sorry to have wasted your time for the first review.

I fixed a few more things (arrow css, better number formatting, ...).

screen shot 2014-12-08 at 19 39 24