Closed dhalperi closed 9 years ago
@domoritz can I ask you to review this three-way PR?
This PR, https://github.com/uwescience/myria/pull/659, and https://github.com/uwescience/myria-python/pull/34.
Sure, I'll review the pr's together and merge at once.
Why did you not add a search box?
Lol, I knew I was forgetting something important....
Daniel Halperin Director of Research for Scalable Data Analytics eScience Institute University of Washington
On Tue, Dec 16, 2014 at 1:10 PM, Dominik Moritz notifications@github.com wrote:
Why did you not add a search box?
— Reply to this email directly or view it on GitHub https://github.com/uwescience/myria-web/pull/237#issuecomment-67232459.
Lol, I knew I was forgetting something important....
I'm personally okay with appending &q=QUERY
to the url but it's not really discoverable.
@domoritz here's as close to pretty a search box as I could get. Man this bootstrap CSS stuff is a pain.
Some relevant threads:
but none of these fully helped.
I made it look a tiny bit nicer.
One issue is remaining. When you do an empty search, q
is set to the empty string but we still only have next/prev pagination.
Fixed in e31e8bf
Requires https://github.com/uwescience/myria/pull/659 .
See discussion there and on #232 for more info.