uwescience / myria-web

Web frontend for Myria
https://demo.myria.cs.washington.edu
Other
11 stars 14 forks source link

Change default to localhost #253

Closed domoritz closed 9 years ago

domoritz commented 9 years ago

We discussed this in the meeting. The reason is that we want local setups to work without having to change the code.

@billhowe

dhalperi commented 9 years ago

Seems reasonable... I guess the question is, what's more common:

Certainly the former case is most common for our group -- only if the myria-web changes necessitate backend changes would someone want to use localhost. Note that the third case will never be well-supported by our default.

I am slightly against this change because it makes myria-web useless on its own, but I don't feel strongly. Feel free to merge if you've consensus.

domoritz commented 9 years ago

The main reason is that we want the myria hello world from the docs to work without code changes. At some point we want a cleaner solution such as a config file or a drop down but for now this was the consensus in the group meeting.