uwescience / myria-web

Web frontend for Myria
https://demo.myria.cs.washington.edu
Other
11 stars 14 forks source link

Fix travis config by removing appengine from requirements-dev.txt #255

Closed hello-josh closed 9 years ago

hello-josh commented 9 years ago

I cloned the repo, initialized the submodules, created and activated a virtualenv, pip installed requirements-dev.txt and then ran the tests using different sdks.

  1. Test 1, using the instructions under Run the tests in the readme.
(jj)Josh@kapbook:myria-web$ ls
LICENSE             customize-bootstrap     google_appengine_1.9.17.zip
README.md           deploy.sh           requirements-dev.txt
appengine           google_appengine        submodules
(jj)Josh@kapbook:myria-web$ nosetests -w appengine --with-gae --exclude-dir={myria,raco,ply,networkx,sqlalchemy} --gae-lib-root=google_appengine

......................
----------------------------------------------------------------------
Ran 22 tests in 2.041s

OK
(jj)Josh@kapbook:myria-web$
  1. Test 2, using the new google cloud sdk's provided appengine installed at /Users/Josh/Developer/google-cloud-sdk/platform/google_appengine
(jj)Josh@kapbook:myria-web$ ls /Users/Josh/Developer/google-cloud-sdk/platform/google_appengine
BUGS            _python_runtime.py  dev_appserver.py    gofmt           php_cli.py
LICENSE         api_server.py       dev_appserver.pyc   google          remote_api_shell.py
README          appcfg.py       download_appstats.py    google_sql.py       run_tests.py
RELEASE_NOTES       backends_conversion.py  endpointscfg.py     goroot          tools
RELEASE_NOTES.go_sdk    bulkload_client.py  gen_protorpc.py     lib         wrapper_util.py
VERSION         bulkloader.py       goapp           new_project_template    wrapper_util.pyc
_php_runtime.py     demos           godoc           php
(jj)Josh@kapbook:myria-web$ nosetests -w appengine --with-gae --exclude-dir={myria,raco,ply,networkx,sqlalchemy} --gae-lib-root=/Users/Josh/Developer/google-cloud-sdk/platform/google_appengine
......................
----------------------------------------------------------------------
Ran 22 tests in 2.055s

OK

Both completed successfully. I was also able to run the app using:

(jj)Josh@kapbook:myria-web$ ./google_appengine/dev_appserver.py appengine
INFO     2015-02-16 21:58:41,467 sdk_update_checker.py:229] Checking for updates to the SDK.
INFO     2015-02-16 21:58:41,579 sdk_update_checker.py:273] This SDK release is newer than the advertised release.
INFO     2015-02-16 21:58:41,587 api_server.py:172] Starting API server at: http://localhost:65288
INFO     2015-02-16 21:58:41,592 dispatcher.py:186] Starting module "default" running at: http://localhost:8080
INFO     2015-02-16 21:58:41,594 admin_server.py:118] Starting admin server at: http://localhost:8000

This is what I get when I hit the URL so I am assuming it works

image

Now we will see if Travis-CI marks this PR as OK! :8ball:

hello-josh commented 9 years ago

Fixes #254

hello-josh commented 9 years ago

Fixed. Would you like me to combine them into a single commit?

dhalperi commented 9 years ago

@Trii no thanks, this is great!