Open bmyerz opened 9 years ago
Quick question. Why don't we put the dropdown for the backend system in the upper right corner into the menu? With the proposed UI, you could choose the C backend but still have the URL to the MyriaX in the menu.
@domoritz I'm not sure I understand your proposal. The URL in the top right changes depending on what is configured in the AppEngine server for that particular backend.
Are you proposing we move the "backend system" dropdown in Editor and the "Backend" dropdown in Datasets and Queries to where the server hostname is?
I'm not sure precisely how this would work at a mechanical level, but it would be very clean if the way you changed backend was via clicking the "connection string", which activated a dropdown.
That may be close to what @domoritz was thinking.
Yes, that was my interpretation and it sounds completely reasonable. I think it would make the page more organized.
Sure, I'll try that change.
(((note the change from grappa-master
to grappa-master-b
.
The former is dead (reason for changing is not worth telling but has to do with radish-server) )))
@TheYorkWei can you reply to Bill's other comments above? If irrelevant then reply as such so we know they are done. They are just hidden because it is on an outdated diff.
@domoritz @billhowe I think we are close to ready to merge.
The main issue with code quality is that the javascript dispatch between backends is not consolidated, but this refactor can happen as needed later.
Sounds right.
After merging this, I figure the plan is to dispatch through the myriaweb REST interface and let RACO handle the dispatch to various backend servers.
On Mon, May 25, 2015 at 4:40 PM, Brandon Myers notifications@github.com wrote:
@domoritz https://github.com/domoritz @billhowe https://github.com/billhowe I think we are close to ready to merge.
The main issue with code quality is that the javascript dispatch between backends is not consolidated, but this refactor can happen as needed later.
— Reply to this email directly or view it on GitHub https://github.com/uwescience/myria-web/pull/270#issuecomment-105336784.
Thanks for the update. There are still a few UX issues. I could not select a different backend because when I selected the select element, it disappeared. Also, there is no hint towards the dropdown.
Please use the dropdowns from http://getbootstrap.com/components/#navbar and change the text shown in the menu instead of hiding the select element.
@TheYorkWei per discussion about fixing chrome select issue, change the dropdown select to a list and use onclick attribute on the <li>
's
@bmyerz I've updated the dropdown list. It works on my browsers, please check your chrome works with the changes.
cool dropdowns seems to work on my chrome now.
@billhowe @domoritz good to merge?
Sorry for not looking at this earlier. Can you merge master into this branch?
These changes let a single myria-web instance interface with multiple backends, specifically: MyriaX, Radish (parallel PGAS programs), and C (sequential C++ programs).
Backend
abstract classclangserver/README.md
), pick C in the dropdown on web interface@billhowe @domoritz Who is the best reviewer for this? cc: @TheYorkWei
previously #269, but switched branches for maintainence
remaining tasks: