uwescience / myria-web

Web frontend for Myria
https://demo.myria.cs.washington.edu
Other
11 stars 14 forks source link

C backend says result is zero tuples #272

Closed bmyerz closed 9 years ago

bmyerz commented 9 years ago

(branch grappa-master #270) The result table is populated correctly but the numTuples field is still 0.

Recreate the bug: scan a non-empty table.

image

I see that the datasets table in radish-server never gets updated, so it is not necessarily just that it reads the 0 too soon.

sqlite> select * from dataset where queryId=9;
userName|programName|relationName|queryId|created|url|status|startTime|endTime|elapsed|numTuples|schema|backend|query
public|adhoc|sp2bpredicates|9|1427827736.64314|http://localhost:1337|SUCCESS|1427827736.64314|1427827738.73232|2089179039.00146|0|{"columnNames": "['subject', 'predicate', 'object']", "columnTypes": "['LONG_TYPE', 'LONG_TYPE', 'LONG_TYPE']"}|clang|sp2bench = scan(public:adhoc:sp2bench);
S1 = select * from sp2bench;

store(S1, sp2bpredicates);
GET http://localhost:1337/data?qid=9&format=csv

[{"columnNames": "['subject', 'predicate', 'object']", "columnTypes": "['LONG_TYPE', 'LONG_TYPE', 'LONG_TYPE']"}, {"tuple": "1,2,3,"}, {"tuple": "1,5,4,"}, {"tuple": "1,100,200,"}]
bmyerz commented 9 years ago

@TheYorkWei Maybe we did this on purpose? I vaguely recall discussing it.

bmyerz commented 9 years ago

requires fix in raco https://github.com/uwescience/raco/commit/a9527c5c2455df46d53d64863d0ffc47d9d5a60c

bmyerz commented 9 years ago

fixed in https://github.com/uwescience/raco/tree/clang-fixups and https://github.com/uwescience/radish-server/commit/6c60345b930da64ede34d8e28555acca44723ea3

image