search

uwescience / myria-web

Web frontend for Myria
https://demo.myria.cs.washington.edu
Other
11 stars 14 forks source link

Changes for the Myria Tutorial - Link to Jupyter and Loading Examples #310

Closed jortiz16 closed 7 years ago

jortiz16 commented 7 years ago

Two changes:

1) Added a link at the top menu bar that points to the Jupyter Notebook.

2) Added a new tab that displays examples for loading different datasets from S3. This "Load Data" tab is now loaded first (before it used to be an "Examples" tab -- but that has been renamed to "Queries").

jortiz16 commented 7 years ago

@senderista I know you're busy atm, so if you can't review this, feel free to reassign. I'm just not sure who else can.

senderista commented 7 years ago

I suck at JS, so I'm not the best person to review most of this. I think my comments above cover all the issues I noticed. Some of the JS seems sloppily formatted, so might use a pass through a formatter.

senderista commented 7 years ago

LGTM