Remove the magic salt for column name conflicts

uwescience / raco

Compilation and rule-based optimization framework for relational algebra. Raco is the language, optimization, and query translation layer for the Myria project.

Other

72 stars 19 forks source link

Remove the magic salt for column name conflicts #541

Open shrjain opened 8 years ago

shrjain commented 8 years ago

Scheme object currently adds a salt (string '1') to disambiguate same column names. This should be replaced with the following:

Update the add_attribute method to not add salt.
Add/Update the get_attribute method to throw a properly constructed exception message when there is a column name conflict.

Overall philosophy should be to let the user do the renames/aliasing and now have implicit fixes.