search

uwescience / raco

Compilation and rule-based optimization framework for relational algebra. Raco is the language, optimization, and query translation layer for the Myria project.
Other
72 stars 19 forks source link

do not regenerate op ids #558

Closed jingjingwang closed 7 years ago

jingjingwang commented 7 years ago

This fixes the random failures of ConnectedComponentTest and JoinChainAndCircleTest -- the op_ids should be unique across the whole query.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.0006%) to 91.72% when pulling 15458526f26dcc10c51da8cf02569ec973a78f7c on fix_op_ids into fc554cf9e5c4bf15ca5ec55d01757cf7641a1fda on master.

senderista commented 7 years ago

@BrandonHaynes could you review, since it looks like you added the reinitialization of op_ids in compile_fragment() that this change removes?

senderista commented 7 years ago

NVM, I see this was the result of a bad merge; the reinitialization was already removed in https://github.com/uwescience/raco/commit/c4db745e674d5793eed889104905d205facc4480.