Fix arguments to variadic (Python) functions

uwescience / raco

Compilation and rule-based optimization framework for relational algebra. Raco is the language, optimization, and query translation layer for the Myria project.

Other

72 stars 19 forks source link

Fix arguments to variadic (Python) functions #559

Closed BrandonHaynes closed 7 years ago

BrandonHaynes commented 7 years ago

Prior to this fix, only positional arguments were allowed. This PR correctly maps arbitrary argument expressions to UDF parameters.

coveralls commented 7 years ago

Coverage increased (+0.008%) to 91.729% when pulling 6b719fb4d67fd62852202f92c56a4561571d01bd on variadic_argument_Fix into 004f76b8de0f0676374b2534e4d68ceb9841d5f7 on master.

coveralls commented 7 years ago

Coverage increased (+0.008%) to 91.729% when pulling d9e3522c4d753503d920e91e42f604f8bdd64cc2 on variadic_argument_Fix into 004f76b8de0f0676374b2534e4d68ceb9841d5f7 on master.

BrandonHaynes commented 7 years ago

@parmitam why are we adding commits unrelated to the fix in this PR?

parmitam commented 7 years ago

I can't test UDAs (or complex UDFs) without SQL supporting the blob type.

parmitam commented 7 years ago

This looks great, ready to checkin.