uweseimet
commented
7 months ago Issues fixed:
- The second REQUEST SENSE after an error returned sense key GOOD, but ASC and ASCQ were not 0. (No relevant practical impact expected.)
- It should be considered to change the MODE SELECT implementation so that devices that support MODE SENSE do not also automatically accept MODE SELECT. (No or low relevant practical impact expected.) Also see https://github.com/uweseimet/scsi2pi/issues/44.
- Wrong phase handling if changing the sector size with MODE SELECT fails. (No relevant practical impact.)
- Wrong error handling when the MODE SELECT parameter list was too short.
s2pexec now quite conveniently supports sending any SCSI command, valid or invalid, with any CDB and any parameter list. This makes advanced testing of the s2p error handling possible. In particular the error handling of s2p shall be verified against the error handling of real SCSI devices. If s2p's behavior differs from that of a real device, based on the SCSI specification the correct error handling shall be determined and s2p shall be updated accordingly.