Reconcile when scatterplot bounds should update - Githubissues

uwgraphics / d3-twodim

A D3.v3.js module for creating 2D representations of data

http://uwgraphics.github.io/d3-twodim/

BSD 3-Clause "New" or "Revised" License

14 stars 10 forks source link

Reconcile when scatterplot bounds should update #18

Closed yelper closed 7 years ago

yelper commented 7 years ago

With commit 8e90a60, bounds() was added to the scatterplot. Handling of the bounds was turned over to the user (the scales do not update unless specifically requested), but if the user wants to change the x- or y-axis, the bounds do not update to the new data domain.

Several options to fix:

Allow the user to specify null bounds so that new bounds will be computed on next redraw (cons: this is too verbose)
Set a flag whenever the mapped data changes, and update bounds automatically on next redraw (cons: what if the user doesn't want the bounds to update?)

yelper commented 7 years ago

Ended up giving control to the user, defaulting to auto-scaling the scatterplot when data selectors are changed.