search

uwhackweek / jupyterbook-template

Template repository for UW Hackweek JupyterBook websites
http://book-template.hackweek.io/
MIT License
9 stars 6 forks source link

Minor github pages deployment fixes #164

Closed scottyhq closed 5 months ago

scottyhq commented 5 months ago

followup to #163, which was hard to test, since we needed to actually run a deployment by merging to main

I also fixed one path here, and it seems to work well https://github.com/uwhackweek/jupyterbook-template/commit/3854ac57bf8419e79e627d7d4e830e9f06906177

Composite workflow does not seem to be picking up step outputs, so removing this, and using whatever is set by default (not sure if it will pick up custom cname, but it's really just a convenience anyways to have the URL easily accessible from the actions log)

Environment URL '' is not a valid http(s) URL, so it will not be shown as a link in the workflow graph.

Also add runner os to actions artifact name (in the case of a matrix job rendering the website on both linux and macos there will not be a name conflict)

github-actions[bot] commented 5 months ago

🚀 Deployed on https://deploy-preview-164--hackweek-template.netlify.app

scottyhq commented 5 months ago

@jomey looks like the sed command on macos is failing sed: 1: "team_people.yaml": undefined label 'eam_people.yaml'

jomey commented 5 months ago

@jomey looks like the sed command on macos is failing sed: 1: "team_people.yaml": undefined label 'eam_people.yaml'

Added an issue here #165

Curious, does it build for your local machine?