search

uwiger / gproc

Extended process registry for Erlang
Apache License 2.0
1.07k stars 232 forks source link

Add modules listing to the app.src file #10

Closed doubleyou closed 12 years ago

doubleyou commented 12 years ago

Newest rebar requires modules listing in the app file by default. Also, might be useful for OTP releases.

uwiger commented 12 years ago

Are you sure about this? I'm running the latest rebar, and it still auto-builds the modules attribute.

doubleyou commented 12 years ago

Weird. Perhaps, you have {validate_app_modules, false} somewhere. Take a look at https://github.com/basho/rebar/blob/master/src/rebar_otp_app.erl#L57 , it uses this validation by default.

Come to think of it, maybe instead we should can ask @dizzyd to make this behave in the old style, replacing the default value from 'true' to 'false'.

dizzyd commented 12 years ago

When using a .app.src file the validation should happen AFTER rebar has generated a list of modules for you. I verified this works as expected just now with current rebar HEAD.

This PR is unnecessary.

uwiger commented 12 years ago

Ok, thanks, Dizzy. I will follow your recommendation then.