Closed tomas-abrahamsson closed 3 years ago
Thanks. Merged.
Would it be possible to get a release that includes this? It would enable dependent projects, to just bump their version of parse_trans, in order to support Erlang 24. One I have in mind is mockgyver. Otoh, if you want to hold off for a while, I guess it is possible for it to point to a specific git revision as well. Just wanted to know what your plans are.
Substitutions in codegen:exprs/1 were expecting locations to be integers. But with Erlang 24, these are {Line, Column} instead. Handle both.
To illustrate the change, I'll use a function in mockgyver_xforms:
With Erlang 23, the parse_trans
codegen:exprs
it gets transformed to the following:With Erlang 24, before this PR, the expression transforms to this:
With this PR, the expression now transforms to the following on Erlang 24:
With this PR and Erlang 23, it still transforms as in the first case.