uwindsorcss / hub

Main website for the Computer Science Society for students to find and register themselves for events, join the Discord server, contribute to our open-source guide for students, and more.
https://css.uwindsor.ca
14 stars 21 forks source link

Name Api only pulled once? #327

Open BadChocMilk opened 1 year ago

BadChocMilk commented 1 year ago

Expected Behaviour

Name should be pulled from the Microsoft Graph Api whenever the application is authorized through the account

Actual Behaviour

Name seems to only be pulled once and never again, even if the name call on Microsoft Graph is completely different

Steps to Reproduce

Authorize using one account name change account name revoke access to app reauthorize under new name old name still displays

I had to get my uWindsor name fixed due to a mistake on their part, however, it seems that the name it used to be was saved and despite no calls to that previous name when testing the Graph API, it is still used. Are the names saved locally? Maybe a check to see if the locally saved name matches the Graph name and if not, update it to the graph name.

jere-mie commented 1 year ago

It's worth noting that while this site is currently in production, it's reached end of life and is no longer being maintained.

We're currently rebuilding this site in Golang, so I'd recommend making an issue there to ensure this behaviour is included in the rewrite (and maybe even adding the implementation yourself!)

You can find the rewrite repo here: https://github.com/uwindsorcss/site