uwindsorcss / wiki

A student-created wiki tailored for CS students
https://uwindsorcss.github.io/wiki/
6 stars 13 forks source link

Change emojis on course offerings #65

Closed ahmadmunim closed 2 years ago

ahmadmunim commented 2 years ago

What are you trying to accomplish?

Change the old emojis to new emojis that are distinguishable and readable based on the program.

How are you accomplishing it?

Change the old emojis which were different colored hearts to emojis which I found to resemble the respective programs while being readable in dark mode. General -> A stack of books Honours -> A graduation hat Applied Computing -> Smartphone Software Engineering -> A gear Business -> Graph Math -> A ruler

Is there anything reviewers should know?

A new file called 'package-lock.json' was created and the file 'yarn.lock' was also modified but I didn't commit those files.

Checks before you create your pull request

prairir commented 2 years ago

Can you give screenshots on what it looks like with lightmode and darkmode please? The emojis visibility is extremely important and was an issue with earlier suggestions

ahmadmunim commented 2 years ago

dark_theme light_theme

abdularif0705 commented 2 years ago

@ahmadmunim I think for Business and CS you can change it to one of these -> πŸ€΅πŸ½πŸ’ΌπŸ‘”

ahmadmunim commented 2 years ago

@abdularif0705 I was initially thinking of using 🀡 for business but I didn't find it readable in dark mode and I decided to avoid using face/person emojis all around. πŸ’Ό or πŸ‘” could work. So I'm okay with changing the current emoji to one of those.

abdularif0705 commented 2 years ago

πŸ‘” ok so I think this emoji would look the best for business

ahmadmunim commented 2 years ago

dark_theme light_theme