Closed briesenberg07 closed 6 years ago
Confirmed that my branch was up-to-date with the upstream repo. Still not sure why previously-merged pull requests are showing up as part of this pull request.
New commits since the last merge ( #5 )begin with:
Created blank nodes for the output from the following Cdm elements:
We had talked about continuing to use dct:identifier > bnode for these elements. However, as dct:identifier has a range of rdfs:Literal I thought it best to use the bf:identifiedBy property.
Let's discuss later?
Improved tokenizing for SubjectsLctgm and SubjectsLcsh values Now tokenizes on a semicolon plus one or more whitespace characters
My comments detailing commits seem superfluous as commit details can be displayed from this page easily. I'm going to stop posting comments reproducing information already included in the commits themselves.
Hello @gerontakos Still not the final commit for the AYP transform--sorry if this is confusing. Will send notice when everything we've discussed has been done in the transform.
@gerontakos
I believe we are ready to merge and move on. Output from the newest transform is in the workingDraftRdfXml folder. Once you've taken a look--assuming you don't find any issues--those files can be used by Crystal for SPARQL cleanup.
Great, thank you!
From: Benjamin Riesenberg [mailto:notifications@github.com] Sent: Friday, August 10, 2018 1:46 PM To: UniverityOfWashingtonLibrariesSchemas/schemasProject schemasProject@noreply.github.com Cc: Theodore Gerontakos tgis@uw.edu; Mention mention@noreply.github.com Subject: Re: [UniverityOfWashingtonLibrariesSchemas/schemasProject] Ongoing AYP transform work (#8)
@gerontakoshttps://github.com/gerontakos
That's everything on the list!
I believe we are ready to merge and move on. Output from the newest transform is in the workingDraftRdfXmlhttps://drive.google.com/drive/folders/1TeAZxCwjwCPzFX7kxrjVwQ6loQ2cpW37?usp=sharing folder. Once you've taken a look--assuming you don't find any issues--those files can be used by Crystal for SPARQL cleanup.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/UniverityOfWashingtonLibrariesSchemas/schemasProject/pull/8#issuecomment-412201228, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGokqKZqOLGjePQxQkE52nFJ12ytb4suks5uPfEFgaJpZM4Vo6ek.
squashed and merged to create v1-0
Closing this for now--previously-merged commits are showing up--I think I need to merge again before I create a new pull request?