search

uwmadison-chm / bioread

Utilities to work with files from BIOPAC's AcqKnowlege software
MIT License
66 stars 23 forks source link

Non 2to3 changes #6

Closed quazgar closed 9 years ago

quazgar commented 9 years ago

And this is the rest of changes, all without 2to3 changes.

njvack commented 9 years ago

Hm... I don't really like adding API for simple_layout. It seems like something people won't generally know if they can set, and if it's set True incorrectly, it'll screw things up.

Really, this is something the code should be able to autodetect.

And really really, I think the whole uncompressed reading algorithm could be improved a lot; there are other requests out there to be able to read just certain channels into memory (say, you have a 6G EEG file) or stream the data.

So I think the better approach is going to be to burn __read_data_uncompressed down and do something better there :neutral_face:

njvack commented 9 years ago

I've cherry-picked some of these, but I'm gonna punt on simple_layout for now.