Visualizer doesn't work with volume or shape.

uwmisl / puddle

A system for high-level, reliable programming of microfluidic devices

http://misl.cs.washington.edu/projects/puddle.html

MIT License

36 stars 10 forks source link

Visualizer doesn't work with volume or shape. #20

Closed mwillsey closed 6 years ago

mwillsey commented 6 years ago

Right now (as of d74a3ca6f500308fb34438ce16546c8fe0533966), the visualizer doesn't work at all. It should:

be fixed to at least show something
support volume
have rudimentary support for shape

We can mostly ignore shape in the visualizer because large droplets never get made, but the support should be there.

chrstnb commented 6 years ago

One issue: rounded-rect

Rounded rectangle is likely not our best option; I tried the whole range of radius options and this was as good as it got. Using ellipse instead.

mwillsey commented 6 years ago

I would say to stick with rounded rect but maybe increase the radius. With ellipse you might find it hard to cover all of the cells in the rectangle when it's large.

mwillsey commented 6 years ago

I tried the whole range of radius options

What do you mean here? I think it's more important to accurately cover all of the cells that the droplet covers.

chrstnb commented 6 years ago

I mean attempting to get it to resemble a circle/ellipse. There's not the best documentation in terms of the relationship between the radius and the dimensions of the object; I think what I have now is close. Was mostly concerned about the note in the docs "In WebGL this must be a value between 0 and 9", but it appears it's not really an issue anymore per this discussion?