search

uwolfer / gerrit-intellij-plugin

Gerrit Code Review Tool Integration for the IntelliJ Platform
Apache License 2.0
491 stars 100 forks source link

Add push extension point #317

Open reda-alaoui opened 6 years ago

reda-alaoui commented 6 years ago

Thank you for this awesome plugin.

We built https://github.com/Cosium/vet which is a Gerrit client CLI widely inspired by git cl from Chromium depot tools. Its purpose is to allow to push to Gerrit without the need to manually rebase the current commit sequence to a unique commit.

The CLI has a command called push that concats multiple commits into one, append the Gerrit change ID on the fly and push the result to Gerrit.

We are currently building https://github.com/Cosium/vet-intellij-plugin to allow its use through the IDE. The easiest way for us to manage the push operation would be to depend on your plugin and override the push action to trigger our own client push action.

Would you accept a PR adding this kind of extension point?

uwolfer commented 6 years ago

@reda-alaoui Sure, I'd happy to accept a PR which makes the plugin more usable for more users.

Just some technical details: How do you want to "modify" pushes? Before the push dialog opens? Or after the push dialog has been shown? Both things are probably not that easy to achieve because my plugin just adds an option panel in the existing IntelliJ push dialog. There is no API for doing that in IntelliJ - that's why it is not very extensible and not implemented in a very clean way.

Please let me know more details about your implementation idea so I can guide you into the right direction.

reda-alaoui commented 6 years ago

@uwolfer , thanks for your answer. We finally chose to depend only on Git4Idea for now. Maybe one day, I will come back with a PR to benefit of this library features :)