Handle topics containing spaces correctly - Githubissues

uwolfer / gerrit-intellij-plugin

Gerrit Code Review Tool Integration for the IntelliJ Platform

Apache License 2.0

495 stars 103 forks source link

Handle topics containing spaces correctly #405

Open kriegaex opened 3 years ago

kriegaex commented 3 years ago

This is a follow-up issue for #404, as requested by @uwolfer.

The "topic" input field permits to enter values containing spaces, but then later the plugin fails to create correct destination references from it.

So if a destination reference containing spaces can be used when quoted, escaped or encoded somehow, please update the plugin in order to add that capability.
Otherwise, please make sure that field validation kicks in in order to avoid users from entering something like "Bug xy" in the topic field.
Please make sure that other input fields, which might have similar issues, are treated correctly as well.

aupuzikov commented 3 years ago

also, can you please trim spaces in all input fields as well