Update toolbar icons to better fit the new UI

uwolfer / gerrit-intellij-plugin

Gerrit Code Review Tool Integration for the IntelliJ Platform

Apache License 2.0

495 stars 102 forks source link

Update toolbar icons to better fit the new UI #467

Closed almas1992 closed 1 year ago

almas1992 commented 1 year ago

Before

After

uwolfer commented 1 year ago

@almas1992: Thanks for your PR! Have you created this icon yourself? I'm asking because of possible licencing issues.

almas1992 commented 1 year ago

@almas1992: Thanks for your PR! Have you created this icon yourself? I'm asking because of possible licencing issues.

Yes, but I just did it based on the original icon

uwolfer commented 1 year ago

After checking IntelliJ docs, it looks like we should move to SVG icons: https://plugins.jetbrains.com/docs/intellij/work-with-icons-and-images.html#svg-format

SVGs are only supported for 2018.2; if you go the SVG way, please create intellij2020.3 branch.

uwolfer commented 1 year ago

I have tried to create an SVG like you did, based on pluginIcon.svg. I am not completely happy, I think yours looks better. But I also noticed that you are using the new UI styling, which uses bigger icons.

My version: gerrit

almas1992 commented 1 year ago

I have tried to create an SVG like you did, based on pluginIcon.svg. I am not completely happy, I think yours looks better. But I also noticed that you are using the new UI styling, which uses bigger icons.

My version:

I create svg icon and submit a new PR #471