search

uwoseis / zephyr

Open-source seismic waveform modelling and inversion code written in Python
https://zephyr.space
MIT License
17 stars 8 forks source link

Incorporate correction for 2D WE #7

Closed bsmithyman closed 8 years ago

bsmithyman commented 8 years ago

Issue by bsmithyman Tuesday Nov 17, 2015 at 19:20 GMT Originally opened as https://github.com/uwoseis/anemoi/issues/7

Need to include a wrapper for the 2D wave equation examples that automatically corrects for the 2D vs. 3D Green's function (i.e., half differentiation, half integration).

bsmithyman commented 8 years ago

Comment by bsmithyman Tuesday Nov 17, 2015 at 19:35 GMT

@ShaunHadden I just added this issue to track the need for handling 2D vs. 3D Green's functions. This is one of the topics that came up in the meeting with Gerhard this morning. It should be semi-general for all of the methods, so we should either implement it in BaseDiscretization, as a wrapper around MiniZephyr and Eurus, or something similar. Just FYI for now.

bsmithyman commented 8 years ago

Comment by ShaunHadden Tuesday Nov 17, 2015 at 19:40 GMT

ok! This says self-assigned to you, so I am assuming no action is required from me, which makes sense since you said these were just FYI

bsmithyman commented 8 years ago

Comment by bsmithyman Tuesday Nov 17, 2015 at 19:48 GMT

Yes, exactly :)

bsmithyman commented 8 years ago

Comment by ShaunHadden Tuesday Nov 17, 2015 at 19:50 GMT

I''ve made the change to the 'Dz' calculation that was wrong on the timedomain branch for eurus.py. This still needs more work so perhaps we should wait to merge it into master?

bsmithyman commented 8 years ago

Comment by bsmithyman Tuesday Nov 17, 2015 at 19:53 GMT

Thanks for letting me know, but we should use these issues to discuss specific topics, and not mix in other issues. I have created a new spot to discuss the Eurus discretization: #8

bsmithyman commented 8 years ago

Closed by #16